Remove admin/nav.tmpl #10633
Merged
Remove admin/nav.tmpl #10633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
added
topic/build
zeripath
approved these changes
Mar 6, 2020
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #10633 +/- ##
=========================================
Coverage ? 43.62%
=========================================
Files ? 588
Lines ? 82474
Branches ? 0
=========================================
Hits ? 35978
Misses ? 42033
Partials ? 4463Continue to review full report at Codecov.
|
lafriks
approved these changes
Mar 6, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't seem to find any reference to this template in the codebase.
admin/navbar.tmplis the one being actively used. Git blame seems to indicate this file was older and replacingnavbar's content with this file produces this:Having two files needing to be updated is confusing from a maintenance perspective - would custom themes be making use of it?