-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Remove svg preload #10654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove svg preload #10654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It triggers a warning in the Chrome console about it being unused, so I think preloading of SVG assets may not be supported properly in current browsers.
Codecov Report
@@ Coverage Diff @@
## master #10654 +/- ##
==========================================
+ Coverage 43.58% 43.6% +0.01%
==========================================
Files 589 589
Lines 82561 82561
==========================================
+ Hits 35988 36004 +16
+ Misses 42112 42101 -11
+ Partials 4461 4456 -5
Continue to review full report at Codecov.
|
lafriks
approved these changes
Mar 7, 2020
guillep2k
approved these changes
Mar 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/miscellaneous
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It triggers a warning in the Chrome console about it being unused, so I think preloading of SVG assets may not be supported properly in current browsers. Remove it for now to avoid the warning.