Skip to content

Remove svg preload #10654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 9, 2020
Merged

Remove svg preload #10654

merged 6 commits into from
Mar 9, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 7, 2020

It triggers a warning in the Chrome console about it being unused, so I think preloading of SVG assets may not be supported properly in current browsers. Remove it for now to avoid the warning.

It triggers a warning in the Chrome console about it being unused, so I
think preloading of SVG assets may not be supported properly in current
browsers.
@codecov-io
Copy link

codecov-io commented Mar 7, 2020

Codecov Report

Merging #10654 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10654      +/-   ##
==========================================
+ Coverage   43.58%    43.6%   +0.01%     
==========================================
  Files         589      589              
  Lines       82561    82561              
==========================================
+ Hits        35988    36004      +16     
+ Misses      42112    42101      -11     
+ Partials     4461     4456       -5
Impacted Files Coverage Δ
modules/indexer/stats/db.go 50% <0%> (-9.38%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
routers/repo/view.go 36.14% <0%> (-0.68%) ⬇️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️
services/pull/temp_repo.go 31.62% <0%> (+2.56%) ⬆️
services/pull/patch.go 64.51% <0%> (+2.58%) ⬆️
modules/git/command.go 89.56% <0%> (+2.6%) ⬆️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️
services/pull/check.go 55.48% <0%> (+5.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d665764...862caec. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 7, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 7, 2020
@lafriks lafriks added type/miscellaneous skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 7, 2020
@lafriks lafriks added this to the 1.12.0 milestone Mar 7, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 7, 2020
@guillep2k guillep2k merged commit ec4d0cd into go-gitea:master Mar 9, 2020
@silverwind silverwind deleted the remove-svg-preload branch March 9, 2020 06:21
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants