Skip to content

Use better wording for release pipeline and steps #10701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

sapk
Copy link
Member

@sapk sapk commented Mar 10, 2020

It was strange that the pipeline for the last commit was named release-master (even for https://drone.gitea.io/go-gitea/gitea/22615).

This PR simply refactor some naming to be more explicit.

I don't think this need to be backported but it will fixed it for later.

@sapk sapk added type/miscellaneous skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 10, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #10701 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10701      +/-   ##
==========================================
- Coverage   43.58%   43.56%   -0.03%     
==========================================
  Files         589      589              
  Lines       82565    82662      +97     
==========================================
+ Hits        35990    36011      +21     
- Misses      42113    42177      +64     
- Partials     4462     4474      +12     
Impacted Files Coverage Δ
modules/indexer/stats/db.go 40.62% <0.00%> (-18.75%) ⬇️
modules/indexer/stats/queue.go 62.50% <0.00%> (-18.75%) ⬇️
modules/lfs/content_store.go 45.33% <0.00%> (-7.80%) ⬇️
modules/lfs/locks.go 45.91% <0.00%> (-4.69%) ⬇️
modules/git/utils.go 65.67% <0.00%> (-4.48%) ⬇️
modules/lfs/server.go 40.35% <0.00%> (-4.25%) ⬇️
modules/log/event.go 64.61% <0.00%> (-1.03%) ⬇️
modules/git/repo.go 46.78% <0.00%> (-0.92%) ⬇️
services/pull/pull.go 34.70% <0.00%> (-0.30%) ⬇️
cmd/serv.go 2.80% <0.00%> (-0.04%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc4f36...781cc90. Read the comment docs.

@lunny
Copy link
Member

lunny commented Mar 11, 2020

make L-G-T-M work.

@lunny lunny merged commit 263c859 into go-gitea:master Mar 11, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants