Skip to content

[UI] language status icon size #10749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 2, 2020
Merged

Conversation

everhopingandwaiting
Copy link
Contributor

adjust the repository language status icon size

before

image

after

image

@silverwind
Copy link
Member

silverwind commented Mar 17, 2020

10px seems too small, old one was ~18px. Suggestion:

.color-icon {
  margin: .5rem 0;
  display: inline-block;
  border-radius: 100%;
  width: 14px;
  height: 14px;
  position: relative;
  top: 1px;
}

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 17, 2020
@lafriks
Copy link
Member

lafriks commented Mar 17, 2020

Yeah, looks a bit too small

@lafriks
Copy link
Member

lafriks commented Mar 17, 2020

14 could probably be more sensible

@everhopingandwaiting
Copy link
Contributor Author

everhopingandwaiting commented Mar 18, 2020

image

@silverwind seems if change the height size to 14px, need to adjust the class of item , otherwise the icon can not align with text

github style:
image

@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #10749 into master will decrease coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10749      +/-   ##
==========================================
- Coverage   43.50%   43.48%   -0.02%     
==========================================
  Files         597      597              
  Lines       83945    83916      -29     
==========================================
- Hits        36517    36488      -29     
- Misses      42914    42917       +3     
+ Partials     4514     4511       -3     
Impacted Files Coverage Δ
services/pull/check.go 50.60% <0.00%> (-4.88%) ⬇️
services/pull/pull.go 34.70% <0.00%> (-0.30%) ⬇️
services/pull/temp_repo.go 31.62% <ø> (ø)
services/pull/update.go 52.54% <50.00%> (+0.26%) ⬆️
modules/process/manager.go 74.69% <0.00%> (-3.62%) ⬇️
modules/git/command.go 86.95% <0.00%> (-2.61%) ⬇️
modules/log/event.go 64.61% <0.00%> (-1.03%) ⬇️
models/error.go 30.49% <0.00%> (-0.54%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c27f3e...dfdcbb9. Read the comment docs.

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Mar 18, 2020
@lafriks lafriks added this to the 1.12.0 milestone Mar 18, 2020
@silverwind
Copy link
Member

seems if change the height size to 14px, need to adjust the class of item , otherwise the icon can not align with text

The position and top in my example is for the vertical alignment. Flexbox centering might even be better.

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to smal ...

@everhopingandwaiting
Copy link
Contributor Author

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 2, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 2, 2020
@lafriks lafriks merged commit 3723b06 into go-gitea:master Apr 2, 2020
@everhopingandwaiting everhopingandwaiting deleted the patch-1 branch April 6, 2020 01:20
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants