Skip to content

[Docs] Config Cheat Sheet: SSL_MODE Value Description #10834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Mar 26, 2020

This PR add description for all SSL_MODE values for both MySQL and PostgreSQL.

@codecov-io
Copy link

Codecov Report

Merging #10834 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10834   +/-   ##
=======================================
  Coverage   43.56%   43.56%           
=======================================
  Files         589      589           
  Lines       82691    82691           
=======================================
+ Hits        36023    36026    +3     
+ Misses      42192    42189    -3     
  Partials     4476     4476           
Impacted Files Coverage Δ
modules/process/manager.go 74.69% <0.00%> (-3.62%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
services/pull/pull.go 35.00% <0.00%> (-0.89%) ⬇️
models/error.go 29.23% <0.00%> (+0.51%) ⬆️
models/gpg_key.go 53.95% <0.00%> (+0.52%) ⬆️
services/pull/check.go 50.00% <0.00%> (+1.82%) ⬆️
modules/indexer/stats/db.go 59.37% <0.00%> (+9.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c331c...d4a501b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 26, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 26, 2020
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Mar 26, 2020
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. I'm not an English native, so I could be a little off too. 😅

Rewording suggestions

Co-Authored-By: guillep2k <[email protected]>
@silverwind
Copy link
Member

Is there a source for these options? Maybe just link to it?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 27, 2020
@guillep2k
Copy link
Member

Ping LG-TM

@guillep2k guillep2k merged commit cac30ab into go-gitea:master Mar 28, 2020
@bagasme
Copy link
Contributor Author

bagasme commented Mar 28, 2020

@silverwind we use go-sql-driver/mysql and lib/pq as driver for both database systems. each driver has their own parameters in which we use here.

@bagasme bagasme deleted the docs/config-cheatsheet-ssl-mode-option-details branch March 28, 2020 09:29
@silverwind
Copy link
Member

I would've just linked to their documentation to eliminate the possibility of it going out of date.

@lafriks
Copy link
Member

lafriks commented Mar 28, 2020

It is easier to put it into our docs as we still validate them in our code and to support new values we would anyway need to add support to that ;)

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants