Skip to content

[Docs] Database Preparation - Connection over TLS #10889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 1, 2020

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Mar 30, 2020

It is possible to connect from Gitea to database instance using TLS.

Currently PostgreSQL supports two-way TLS, but MySQL only supports one-way TLS.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 30, 2020
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Mar 30, 2020
- have been created [before -> earlier]
- recreate user, [and this time]
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2020
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clarifications and tidying up.

@guillep2k guillep2k added this to the 1.12.0 milestone Apr 1, 2020
@codecov-io
Copy link

codecov-io commented Apr 1, 2020

Codecov Report

Merging #10889 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10889      +/-   ##
==========================================
- Coverage   43.50%   43.48%   -0.02%     
==========================================
  Files         597      597              
  Lines       83945    83945              
==========================================
- Hits        36517    36506      -11     
- Misses      42914    42923       +9     
- Partials     4514     4516       +2     
Impacted Files Coverage Δ
services/pull/check.go 50.00% <0.00%> (-5.49%) ⬇️
modules/process/manager.go 74.69% <0.00%> (-3.62%) ⬇️
modules/git/command.go 86.95% <0.00%> (-2.61%) ⬇️
services/pull/patch.go 61.93% <0.00%> (-2.59%) ⬇️
services/pull/temp_repo.go 29.05% <0.00%> (-2.57%) ⬇️
services/pull/pull.go 35.88% <0.00%> (+0.88%) ⬆️
models/unit.go 44.44% <0.00%> (+2.46%) ⬆️
modules/indexer/stats/db.go 50.00% <0.00%> (+9.37%) ⬆️
modules/indexer/stats/queue.go 81.25% <0.00%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbb0880...ff200be. Read the comment docs.

@guillep2k
Copy link
Member

Ping LG-TM

@guillep2k guillep2k merged commit 51140a9 into go-gitea:master Apr 1, 2020
@guillep2k
Copy link
Member

Thank you for your work. Docs is an area where Gitea needs to improve, so these PRs are much welcomed. ❤️

@bagasme bagasme deleted the docs/database-prep-tls branch May 18, 2020 00:57
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants