Skip to content

Upgrade golangci-lint to 1.24.0 #10894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

Upgrade golangci-lint to 1.24.0 #10894

merged 1 commit into from
Mar 30, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 30, 2020 •
edited
Loading

  • upgrade golangci-lint to 1.24.0 to allow go 1.14 compatibility
  • fix golangci-lint errors
  • make make golangci-lint work when out of go-path

Signed-off-by: Andrew Thornton [email protected]

@zeripath
Upgrade golangci-lint to 1.24.0
3f7b344 
* upgrade golangci-lint to 1.24.0 to allow go 1.14 compatibility
* fix golangci-lint errors
* make make golangci-lint work when out of go-path

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 30, 2020
@zeripath zeripath added this to the 1.12.0 milestone Mar 30, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 30, 2020
6543
6543 approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finaly be able to run it localy again - thanks!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 30, 2020
@lafriks lafriks merged commit bf847b9 into go-gitea:master Mar 30, 2020
@zeripath zeripath deleted the golangci-lint branch March 30, 2020 19:04
@silverwind
Copy link
Member

Note that this will not upgrade locally installed golangci-lint because it only checks for existance of any binary. I guess we have that kind of issue on all globally installed binaries.

@zeripath
Copy link
Contributor Author

yeah

@zeripath
Copy link
Contributor Author

This is where coolaj plan of vendoring/go.modding the build dependencies would be helpful

@jolheiser
Copy link
Member

Or a Docker image with the tools injected into the container. (Though that wouldn't help local testing.)

@techknowlogick
Copy link
Member

I guess we have that kind of issue on all globally installed binaries.

There was previously a suggestion of vendoring tools such as this via go modules, perhaps that could be revisited (although if we ever get rid of vendored go, then at least keep it in go modules file)

@silverwind
Copy link
Member

Yes, something with go modules would be ideal because global installs can conflict with other projects that may require different versions of those tools.

@lunny
Copy link
Member

lunny commented Mar 31, 2020

We should make GO111MODUlE=on as default on makefile.

@6543
Copy link
Member

6543 commented Mar 31, 2020

It's in my .bashrc :D

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
9 participants
@zeripath @silverwind @jolheiser @techknowlogick @lunny @6543 @mrsdizzie @lafriks @GiteaBot