-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
add 'make watch-frontend' and expand docs #10931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7b1e257
to
61b8b56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need it
Codecov Report
@@ Coverage Diff @@
## master #10931 +/- ##
=======================================
Coverage 43.50% 43.50%
=======================================
Files 597 597
Lines 83916 83916
=======================================
+ Hits 36504 36510 +6
+ Misses 42903 42899 -4
+ Partials 4509 4507 -2
Continue to review full report at Codecov.
|
Imho built in option would be better |
@lafriks yes a single command would be preferred but doing that also opens up issue that the runtime depends on the existance |
@silverwind not really, it could be special flag to gitea web command that you can run that would start npx webpack. Something like |
or we could even detect if gitea is started in development mode and |
Yeah that could be added later (and this task be removed again), but I still think it's worthwile to have now (at least it saves me from typing that long command every time 😉). |
If I may, I'd rather not pollute the binary with dev options. It's not likely that anyone would not have the source files when doing front-end development, unless of course they're only working on a UI theme; but even then, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a Make target is way more better than a bigger gitea binary and more dependencys
Ping LG-TM |
* add 'make watch-frontend' and expand docs * add bindata note * add .PHONY Co-authored-by: guillep2k <[email protected]>
Not perfect as it requires two terminals, but it's still builds much faster then running the full build. Also, the dev mode of webpack enables additional logging in the browser console, so this should be the go-to mode for frontend development.