Skip to content

fix compare button failed when there is no fork repos #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 3, 2017

fix #936 and deprecate #948

@lunny lunny added the type/bug label Mar 3, 2017
@lunny lunny added this to the 1.1.0 milestone Mar 3, 2017
@appleboy
Copy link
Member

appleboy commented Mar 3, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 3, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2017
@appleboy
Copy link
Member

appleboy commented Mar 3, 2017

build fails

# code.gitea.io/gitea/vendor/github.com/boltdb/bolt
vendor/github.com/boltdb/bolt/db.go:98: undefined: maxMapSize
vendor/github.com/boltdb/bolt/db.go:98: invalid array bound maxMapSize
2017/03/03 02:33:36 Failed to cross compile package: exit status 2.
Makefile:108: recipe for target 'release-build' failed
make: *** [release-build] Error 1

Same errors :(

@lunny
Copy link
Member Author

lunny commented Mar 3, 2017

Yes, it's the new arch mips doesn't supported by boltdb.

@lunny lunny merged commit d2165a5 into go-gitea:master Mar 3, 2017
@lunny lunny deleted the lunny/compare_404_3 branch March 3, 2017 08:54
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compare-Button leads to 404
4 participants