fix some bug about Request review #11040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix ``CreateComment`` wrong using ,it will not work when use Sqlite * fix wrong js click event code , it will send wrong data when it has many choices Signed-off-by: a1012112796 <[email protected]>
lafriks
approved these changes
Apr 10, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
requested changes
Apr 10, 2020
Co-Authored-By: Lauris BH <[email protected]>
mrsdizzie
approved these changes
Apr 10, 2020
GiteaBot
added
lgtm/done
lafriks
approved these changes
Apr 10, 2020
6543
reviewed
Apr 10, 2020
|
@a1012112796 |
|
for GetReviewerByIssueIDAndUserID: rename it to getReviewerByIssueIDAndUserID and create a second function caled GetReviewerByIssueIDAndUserID witch use getReviewerByIssueIDAndUserID similar to what you can find here: Lines 768 to 773 in bc362ea |
|
then use getReviewerByIssueIDAndUserID in RemoveRewiewRequest - thanks! |
fix wrong conditions check in initIssueComments after go-gitea#10972
|
@6543 done your suggestion, please review . Thanks |
Codecov Report
@@ Coverage Diff @@
## master #11040 +/- ##
==========================================
+ Coverage 43.47% 43.49% +0.02%
==========================================
Files 597 597
Lines 84704 84706 +2
==========================================
+ Hits 36821 36841 +20
+ Misses 43341 43327 -14
+ Partials 4542 4538 -4
Continue to review full report at Codecov.
|
guillep2k
added
the
skip-changelog
guillep2k
approved these changes
Apr 11, 2020
|
@a1012112796 thanks, it was exactly what I ment :) |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
…-gitea#11040) * fix some bug about Request review * fix ``CreateComment`` wrong using ,it will not work when use Sqlite * fix wrong js click event code , it will send wrong data when it has many choices Signed-off-by: a1012112796 <[email protected]> * Apply suggestions from code review Co-Authored-By: Lauris BH <[email protected]> * add getReviewerByIssueIDAndUserID fix wrong conditions check in initIssueComments after go-gitea#10972 * call CI again Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: guillep2k <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateCommentwrong using ,it will not work when use Sqlite