Skip to content

ui: fix lable vertical alignment in code search result view #11051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Apr 12, 2020

As Semantic UI default define , the style of detail in lable is vertical-align: top, which will make the number higher than words. I think it's not good view, so redefined it as vertical-align: baseline

from:
jf1


to:
jf2

jf

As Semantic UI default define , the style of detail in lable
is ``vertical-align: top``, which will make the number higher
than words. I think it's not good view, so redefined it as
``vertical-align: baseline``

Signed-off-by: a1012112796 <[email protected]>
@lafriks
Copy link
Member

lafriks commented Apr 12, 2020

It should be defined in less file

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 12, 2020
@silverwind
Copy link
Member

I'd add .language-label class and to those labels and do:

.language-label {
    display: inline-flex;
    align-items: center;
}

.language-label .color-icon {
   position: static;
}

@a1012112796
Copy link
Member Author

I'd add .language-label class and to those labels and do:

.language-label {
    display: inline-flex;
    align-items: center;
}

.language-label .color-icon {
   position: static;
}

That's great, Thanks, so this PR can be closed now.

@silverwind
Copy link
Member

Are you going to open another or should I?

@a1012112796
Copy link
Member Author

Are you going to open another or should I?

Looking forward to your better solution. :)
Thanks

@a1012112796 a1012112796 deleted the fix_code_lable branch April 13, 2020 13:16
@silverwind
Copy link
Member

#11061

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants