Skip to content

Support organization labels for PRs in API #11135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 20, 2020
Merged

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Apr 19, 2020

This PR fixes /repos/{owner}/{repo}/pulls and /repos/{owner}/{repo}/pulls/{index} to accept organization labels during PR creation and edition.

@CirnoT CirnoT marked this pull request as ready for review April 19, 2020 16:35
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 19, 2020
@mrsdizzie
Copy link
Member

sorry I forgot these

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2020
@zeripath zeripath added this to the 1.12.0 milestone Apr 20, 2020
@zeripath
Copy link
Contributor

I think this is a skip changelog as the feature was introduced in 1.12 and it's a bug fix for the feature.

@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #11135 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11135      +/-   ##
==========================================
+ Coverage   43.22%   43.24%   +0.01%     
==========================================
  Files         601      601              
  Lines       85544    85563      +19     
==========================================
+ Hits        36980    37004      +24     
+ Misses      43999    43986      -13     
- Partials     4565     4573       +8     
Impacted Files Coverage Δ
routers/api/v1/repo/pull.go 33.80% <0.00%> (-0.93%) ⬇️
services/pull/update.go 52.54% <0.00%> (-6.78%) ⬇️
services/pull/temp_repo.go 31.62% <0.00%> (-2.57%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
modules/notification/webhook/webhook.go 39.61% <0.00%> (-0.59%) ⬇️
models/issue.go 51.48% <0.00%> (-0.47%) ⬇️
modules/git/repo.go 50.62% <0.00%> (-0.42%) ⬇️
services/pull/pull.go 33.96% <0.00%> (-0.20%) ⬇️
models/pull.go 52.19% <0.00%> (+0.77%) ⬆️
models/repo_language_stats.go 69.02% <0.00%> (+2.65%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77171ab...9befed9. Read the comment docs.

Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block as per @6543 comment

@CirnoT CirnoT requested review from 6543 and lafriks April 20, 2020 11:21
@6543
Copy link
Member

6543 commented Apr 20, 2020

@lafriks I'm ok with it now
@CirnoT thanks for fixing 👍

@zeripath
Copy link
Contributor

aw crap sorry I missed that error!

@zeripath zeripath merged commit d2693f1 into go-gitea:master Apr 20, 2020
@CirnoT CirnoT deleted the patch-5 branch April 21, 2020 15:29
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Fix `/repos/{owner}/{repo}/pulls` and `/repos/{owner}/{repo}/pulls/{index}` to accept organization labels during PR creation and edition.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants