Skip to content

Prevent xorm nil insert in Review.Comments #11150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2020
Merged

Prevent xorm nil insert in Review.Comments #11150

merged 2 commits into from
Apr 20, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 20, 2020

as title

would say lable: skip-changelog?

@techknowlogick techknowlogick added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 20, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Apr 20, 2020
@zeripath zeripath changed the title FIX just another nil insert Prevent nil insert in Review.Comments Apr 20, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 20, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #11150 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11150      +/-   ##
==========================================
- Coverage   43.25%   43.24%   -0.01%     
==========================================
  Files         601      601              
  Lines       85543    85544       +1     
==========================================
- Hits        37001    36993       -8     
- Misses      43966    43974       +8     
- Partials     4576     4577       +1
Impacted Files Coverage Δ
models/review.go 29.57% <0.00%> (-0.07%) ⬇️
services/pull/temp_repo.go 34.18% <0.00%> (-3.42%) ⬇️
modules/git/repo.go 49.79% <0.00%> (-1.26%) ⬇️
services/pull/pull.go 33.20% <0.00%> (-0.77%) ⬇️
modules/queue/unique_queue_disk_channel.go 55.76% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e37e217...07d5013. Read the comment docs.

@zeripath zeripath merged commit 77171ab into go-gitea:master Apr 20, 2020
@6543 6543 deleted the fix-migration-2 branch April 20, 2020 03:04
@zeripath zeripath changed the title Prevent nil insert in Review.Comments Prevent xorm nil insert in Review.Comments Apr 20, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Prevent xorm nil insert in Review.Comments (go-gitea#11150)
5bdf8e1
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @codecov-io @lunny @zeripath @techknowlogick @GiteaBot