Fix creation of Organization repos by Users with max created personal repos #11183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11183 +/- ##
==========================================
- Coverage 43.34% 43.20% -0.14%
==========================================
Files 601 604 +3
Lines 85675 86058 +383
==========================================
+ Hits 37133 37181 +48
- Misses 43956 44287 +331
- Partials 4586 4590 +4
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
guillep2k
reviewed
Apr 24, 2020
Add a note for user.CanCreateRepo() about failure assumptions Change repo.create help message
guillep2k
approved these changes
Apr 26, 2020
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
|
make lg-tm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
… repos (go-gitea#11183) * Fix creation of Org repos Fix go-gitea#9269 * Change variable name to appease linter * Update PR with suggestions Add a note for user.CanCreateRepo() about failure assumptions Change repo.create help message Co-authored-by: guillep2k <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of Organization repositories by Users with the maximum number of personal repositories is currently broken. Instead of crashing or giving an error message, don't display Organizations with the maximum number of repositories in the dropdown.
This will not change the initial selection in the dropdown as that is generated from the context. This will also not remove the user from the list if their number of repositories is at or beyond the maximum. It will also not affect Administrators, though that is intended.
Fix #9269