Slight performance changes to integrations/git_test.go #11227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zeripath
commented
Apr 27, 2020
zeripath
commented
- Stop cloning the large repos in the push-to-create test - they unnecessarily slow for testing this feature which does not need them
- Stop using crypto/rand for generating the data in the commits - pseudo random is sufficient - and stop creating 128Mb buffers in memory.
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/testing
skip-changelog
Signed-off-by: Andrew Thornton <[email protected]>
6543
approved these changes
Apr 27, 2020
GiteaBot
added
the
lgtm/need 1
|
Gain around 3-5min (better than nothing) |
lafriks
approved these changes
Apr 27, 2020
GiteaBot
added
lgtm/done
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* switch to use pseudorandom generator and stop cloning in pushcreate Signed-off-by: Andrew Thornton <[email protected]> * Add some logging of BranchProtectPRMerge Signed-off-by: Andrew Thornton <[email protected]> * Stop running prepareTestEnv so often for TestAPIGetBranch Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.