Skip to content

Use keys.openpgp.org instead of pgp.mit.edu #11249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2020

Conversation

zeripath
Copy link
Contributor

The SKS Keyserver network has been under attack with poisoned
certificates since at least 2019. Downloading a poisoned certificate has
the awful side-effect of completely breaking your keyring and most
software has now moved off the network and uses the keys.openpgp.org
which has a different protocol instead - in fact one whereby emails are
verified.

For more details regarding the attack see: https://gist.github.com/rjhansen/67ab921ffb4084c865b3618d6955275f

See: https://keys.openpgp.org/about and https://keys.openpgp.org/about/faq

Signed-off-by: Andrew Thornton [email protected]

The SKS Keyserver network has been under attack with poisoned
certificates since at least 2019. Downloading a poisoned certificate has
the awful side-effect of completely breaking your keyring and most
software has now moved off the network and uses the keys.openpgp.org
which has a different protocol instead - in fact one whereby emails are
verified.

For more details regarding the attack see: https://gist.github.com/rjhansen/67ab921ffb4084c865b3618d6955275f

See: https://keys.openpgp.org/about and https://keys.openpgp.org/about/faq

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added the type/docs This PR mainly updates/creates documentation label Apr 29, 2020
@ghost
Copy link

ghost commented Apr 29, 2020

Just a quick note: gpg --keyserver ... is deprecated. This should go in dirmngr.conf now. Refer to the info docs on GnuPG for details.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 29, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2020
@codecov-io
Copy link

Codecov Report

Merging #11249 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11249      +/-   ##
==========================================
- Coverage   43.29%   43.29%   -0.01%     
==========================================
  Files         605      605              
  Lines       86204    86204              
==========================================
- Hits        37323    37319       -4     
- Misses      44287    44292       +5     
+ Partials     4594     4593       -1     
Impacted Files Coverage Δ
services/pull/patch.go 65.73% <0.00%> (-3.50%) ⬇️
services/pull/temp_repo.go 31.62% <0.00%> (-2.57%) ⬇️
models/unit.go 41.97% <0.00%> (-2.47%) ⬇️
modules/git/repo.go 49.79% <0.00%> (-1.26%) ⬇️
modules/queue/workerpool.go 58.00% <0.00%> (+2.13%) ⬆️
modules/process/manager.go 78.31% <0.00%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf5dff...3028ec2. Read the comment docs.

@lafriks lafriks merged commit 1853131 into go-gitea:master Apr 30, 2020
@zeripath zeripath deleted the no-pgp.mit.edu branch April 30, 2020 09:34
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
The SKS Keyserver network has been under attack with poisoned
certificates since at least 2019. Downloading a poisoned certificate has
the awful side-effect of completely breaking your keyring and most
software has now moved off the network and uses the keys.openpgp.org
which has a different protocol instead - in fact one whereby emails are
verified.

For more details regarding the attack see: https://gist.github.com/rjhansen/67ab921ffb4084c865b3618d6955275f

See: https://keys.openpgp.org/about and https://keys.openpgp.org/about/faq

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants