Fix /api/v1/orgs/* endpoints by changing parameter to :org from :orgname #11378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iondune nothing against your solution but this make swagger docs to macron param same + fix other apis ... |
GiteaBot
added
the
lgtm/need 2
zeripath
changed the title
zeripath
approved these changes
May 11, 2020
GiteaBot
added
lgtm/need 1
|
Close as already fixed, need only backport to 1.11.6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /api/v1/orgs/* routes previously had :orgname however, all of the functions require :org.
This PR switches these back to :org.
#11332 was only a partial fix but broke multiple other orgs route in the process.
Fix #11331
Close #11332