Skip to content

Fix .comment-code-cloud not being removed when cancelling new code comment #11464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 17, 2020

Introduced by #11139

Fixes this:
chrome_2020-05-17_20-55-25

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 17, 2020
@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI backport/v1.12 labels May 17, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2020
@lafriks lafriks merged commit ef5f176 into go-gitea:master May 17, 2020
@lafriks
Copy link
Member

lafriks commented May 17, 2020

please send backport to release/v1.12 branch

lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request May 17, 2020
@CirnoT CirnoT deleted the code-comment-cancel branch May 17, 2020 20:56
@lafriks lafriks added the backport/done All backports for this PR have been created label May 17, 2020
zeripath pushed a commit that referenced this pull request May 18, 2020
…1467)

* Fix styling of resolved code comment box (#11463)

Co-authored-by: Lauris BH <[email protected]>

* Fix .comment-code-cloud not being removed when cancelling new code comment (#11464)

* Fix footer padding for comment code reply form on issue event view (#11469)

Co-authored-by: Cirno the Strongest <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants