Skip to content

Fix margin on PR form #11566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 25, 2020
Merged

Fix margin on PR form #11566

merged 5 commits into from
May 25, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 22, 2020

Before:
chrome_2020-05-22_23-48-57

After:
chrome_2020-05-22_23-48-27

@CirnoT
Copy link
Contributor Author

CirnoT commented May 22, 2020

Most likely introduced by Fomantic switch, is present in 1.11.5

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 22, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 23, 2020
@lafriks lafriks added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI labels May 23, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented May 24, 2020

Why remove backport to v1.11? The issue is present there as well.

@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit f2a0be1 into go-gitea:master May 25, 2020
@CirnoT CirnoT deleted the pr-form-margin branch May 25, 2020 13:38
CirnoT added a commit to CirnoT/gitea that referenced this pull request May 25, 2020
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 25, 2020
techknowlogick pushed a commit that referenced this pull request May 26, 2020
* Fix inconsistent font size for markdown preview on new PR view (#11565)

We use same method for new issue form and issue view, but was missing from new PR view making it one place where markdown preview is inconsistent in font size.

(cherry picked from commit 04afd9d)

* Fix margin on PR form (#11566)

(cherry picked from commit f2a0be1)

* Fix margin for attached top header on code review (#11571)

Introduced naively by #11463

The margin was being applied too widely.

(cherry picked from commit e682a92)

* Fix styling for PR merge section when no checks (#11609)

Makes styling consistent between two cases. Also removed unnecessary double border.

* Normalize avatar radius
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants