Update emoji regex #11584
Merged
Update emoji regex #11584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When matching emoji, use a regex built from the data we have instead of something generic using unicode ranges. A generic regex can't tell the difference between two separate emoji next to each other or one emoji that is built out of two separate emoji next to each other. This means that emoji that are next to each other without space in between will be now accurately spanned individually with proper title etc...
6543
approved these changes
May 23, 2020
GiteaBot
added
the
lgtm/need 1
Sort dataset from largest to smallest so that emjois that are made up of a combination of other emojis will match first before matching just one of them
|
Looks good. Can't we use finding |
lafriks
approved these changes
May 26, 2020
GiteaBot
added
lgtm/done
|
@lafriks this one isn't for short codes -- it is for unicode points for literal emoji The short code one already does do that, finds the text between : and then does a map lookup. |
|
I think this should be back port to 1.12 also since it fixes some code not released yet |
|
make lg-tm work |
|
When you're quite ready LGTM... |
|
@mrsdizzie I think you're right. I've marked this as kind/bug too. |
|
Please send backport |
mrsdizzie
added a commit
to mrsdizzie/gitea
that referenced
this pull request
May 29, 2020
When matching emoji, use a regex built from the data we have instead of something generic using unicode ranges. A generic regex can't tell the difference between two separate emoji next to each other or one emoji that is built out of two separate emoji next to each other. This means that emoji that are next to each other without space in between will be now accurately spanned individually with proper title etc...
zeripath
pushed a commit
that referenced
this pull request
May 29, 2020
When matching emoji, use a regex built from the data we have instead of something generic using unicode ranges. A generic regex can't tell the difference between two separate emoji next to each other or one emoji that is built out of two separate emoji next to each other. This means that emoji that are next to each other without space in between will be now accurately spanned individually with proper title etc...
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
When matching emoji, use a regex built from the data we have instead of something generic using unicode ranges. A generic regex can't tell the difference between two separate emoji next to each other or one emoji that is built out of two separate emoji next to each other. This means that emoji that are next to each other without space in between will be now accurately spanned individually with proper title etc...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace regex matching with string index matching from our existing list of known emoji. This makes it more performant and now accurately matches two emoji next to each other (previously didn't always know the difference between two emoji and one emoji made up of two separate emoji)