-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix visibility of forked public repos from private orgs #11717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Added logic to update forks visibility when org visibility has changed. |
For initial yes but I don't think it is good idea to update visibility on main repository visibility change. |
I don't understand. Forked repositories always follow parent, the visibility can not be changed on fork - ever. This PR only fixes it so that organization visibility is also included. This is a security fix as public repository of private organization is visible only to organization members, but upon forking it's visible to everyone. In addition forking can not be disabled so organization owner can never prevent leakage of public repos in a private org. That being said I agree that forks of public repo should not follow parent when it goes into private mode; in particular this should be solved by decoupling forks from parent (turning them into normal repositories) once parent becomes private. But that is out of the scope for this PR. |
Ready for merge, addressed @guillep2k questions here: #11717 (comment) |
make lg-tm work |
ping LG-TM |
* Fix visibility of forked public repos from private orgs * update forks visibility when org visibility is changed Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Ensure that public repos of private orgs (so called internal repos, visible only to members of organization) are set as private when forked.
Most likely kind/security