Skip to content

Re-center the cog on the center of the lock #11844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

zeripath
Copy link
Contributor

At some point during the 1.13 branch the centering of the cog on the lock that indicates a signed commit signed by the system provided key has gone off centre. It appears correct on 1.12 but is now 0.45em off center of the lock body. This PR restores the previous position.

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Jun 10, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jun 10, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 10, 2020
@lafriks lafriks added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2020
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace these with custom SVGs at some point

@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jun 10, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit 8ffc0ed into go-gitea:master Jun 10, 2020
@zeripath zeripath deleted the fix-centerlock-position branch June 10, 2020 21:10
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants