Skip to content

Fix missing styling for dropdown icon on review button #11998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 22, 2020
Merged

Fix missing styling for dropdown icon on review button #11998

merged 5 commits into from
Jun 22, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jun 20, 2020

After:
firefox_2020-06-20_21-18-09
Before:
firefox_2020-06-20_21-18-32
After:
firefox_2020-06-20_21-19-05
Before:
firefox_2020-06-20_21-19-14

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 20, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented Jun 20, 2020

Aside from icon being misaligned, there is very slight height difference due to font-size.

The styling applied is identical to one that Fomantic applies on .ui.dropdown:not(.labeled) > .dropdown.icon - it's missing on this button due to dropdown being applied on parent div, not button itself.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 20, 2020
@lafriks lafriks added topic/ui Change the appearance of the Gitea UI and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Jun 20, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jun 20, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 20, 2020
@CirnoT CirnoT marked this pull request as draft June 20, 2020 19:32
@CirnoT CirnoT marked this pull request as ready for review June 20, 2020 19:37
@CirnoT
Copy link
Contributor Author

CirnoT commented Jun 20, 2020

Found out that the span element was causing another .1 height difference.

@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jun 20, 2020
@lafriks
Copy link
Member

lafriks commented Jun 22, 2020

🚀

@lafriks lafriks merged commit 180286d into go-gitea:master Jun 22, 2020
@CirnoT CirnoT deleted the review-btn-dropdown branch June 22, 2020 00:18
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT @lunny @lafriks
Fix missing styling for dropdown icon on review button (go-gitea#11998)
6c006d5 
* Fix missing styling for dropdown icon on review button

* Remove unnecessary span element

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@CirnoT @lafriks @silverwind @GiteaBot @lunny