Skip to content

Add the bindata source as a target to the Makefile #12367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add the bindata source as a target to the Makefile #12367

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89438ea
Add the bindata source as a target to the Makefile
zeripath Jul 29, 2020
4e89d62
Update Makefile
zeripath Jul 29, 2020
efeed6d
If we are building the frontend - only generate after the frontend is…
zeripath Jul 29, 2020
ff63be4
Try to avoid node-check
zeripath Jul 29, 2020
7c266fd
Use .NOTPARALLEL
zeripath Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,9 +526,12 @@ frontend: node-check $(FOMANTIC_DEST) $(WEBPACK_DEST)
backend: go-check generate $(EXECUTABLE)

.PHONY: generate
.NOTPARALLEL: generate
Copy link
Member

@silverwind silverwind Jul 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I gather .NOTPARALLEL does not take any arguments, just plain .NOTPARALLEL: anywhere in the makefile should disable parallelism for the whole makefile.

generate: $(TAGS_PREREQ)
CC= GOOS= GOARCH= $(GO) generate -mod=vendor -tags '$(TAGS)' $(GO_PACKAGES)

$(BINDATA_DEST): generate

$(EXECUTABLE): $(GO_SOURCES) $(TAGS_PREREQ)
CGO_CFLAGS="$(CGO_CFLAGS)" $(GO) build -mod=vendor $(GOFLAGS) $(EXTRA_GOFLAGS) -tags '$(TAGS)' -ldflags '-s -w $(LDFLAGS)' -o $@

Expand Down