Split up monaco's language chunks #12401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should speed up monaco's loading time by splitting the current 3.71MB chunk monaco.js into 63 individual files named 1 to 63.js in the output directory. There seems to be no way to get a better file naming scheme unfortunately. I opted to exclude those files in the webpack output for brevity.
zeripath
approved these changes
Aug 1, 2020
GiteaBot
added
the
lgtm/need 1
|
Didn't monaco support load by language asynchronize? |
|
Yes it does load async but we inhibited efficient loading previously by combining the language chunks into one, forcing it to load the big 4MB file initially which had bundled all the language files into it. With this change, it will initially load the 2.2MB file and then dynamically load the smaller per-languague files (those just with numbers in the name) on-demand and this is also the recommended way. You can see this happening in the devtools, for example when editing a JS file:
|
lunny
approved these changes
Aug 2, 2020
GiteaBot
added
lgtm/done
lunny
added
the
type/refactoring
|
make lg-tm work |
|
make lg-tm work already? |
lafriks
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed up monaco's loading time by splitting the current 3.71MB chunk monaco.js into 63 individual files named 1 to 63.js in the output directory. There seems to be no way to get a better file naming scheme unfortunately. I opted to exclude those files in the webpack output for brevity.
(This is a exact revival of #12193)