Skip to content

Match GH with Commit page #12425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Conversation

techknowlogick
Copy link
Member

fix #12296

@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Aug 4, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 4, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 4, 2020
@lunny lunny merged commit 6ab4d76 into go-gitea:master Aug 5, 2020
@lunny
Copy link
Member

lunny commented Aug 5, 2020

Please send backport

@techknowlogick techknowlogick deleted the techknowlogick-patch-5 branch August 5, 2020 02:36
techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Aug 5, 2020
lunny pushed a commit that referenced this pull request Aug 5, 2020
Co-authored-by: zeripath <[email protected]>

Co-authored-by: zeripath <[email protected]>
@CirnoT
Copy link
Contributor

CirnoT commented Aug 5, 2020

Don't really see much point of it given that email is still visible in commit message (Gitea adds fields like Reviewed-by and Co-authored-by) and on user profile page. At the very least it shouldn't close mentioned issue.

@CirnoT
Copy link
Contributor

CirnoT commented Aug 5, 2020

Oh also email is visible on signed commit signature
chrome_2020-08-05_12-09-51

@lafriks
Copy link
Member

lafriks commented Aug 5, 2020

Does github hide emails somehow in commit messages?

@silverwind
Copy link
Member

I think GH preserves original commit messages (incuding emails) but never adds emails by itself (in contrast to gitea which may according to comments here).

@zeripath
Copy link
Contributor

zeripath commented Aug 5, 2020

@lafriks If the user matches then they don't display the email address but you can always get the real email by adding an appropriate suffix to the commit url.

I do wonder if they realise that - or even that they can just pull the damned git sources themselves over http?

Or is the issue the rate limiting? Maybe that's where we need focus next?

@lafriks lafriks added the backport/done All backports for this PR have been created label Aug 5, 2020
@lafriks
Copy link
Member

lafriks commented Aug 5, 2020

It's hard to rate limit anyway if they are using tons of random IP addresses

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signed commits reveal email addresses (and spammers are scraping Gitea for email addresses)
7 participants