-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Match GH with Commit page #12425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match GH with Commit page #12425
Conversation
Please send backport |
Co-authored-by: zeripath <[email protected]>
Co-authored-by: zeripath <[email protected]> Co-authored-by: zeripath <[email protected]>
Don't really see much point of it given that email is still visible in commit message (Gitea adds fields like Reviewed-by and Co-authored-by) and on user profile page. At the very least it shouldn't close mentioned issue. |
Does github hide emails somehow in commit messages? |
I think GH preserves original commit messages (incuding emails) but never adds emails by itself (in contrast to gitea which may according to comments here). |
@lafriks If the user matches then they don't display the email address but you can always get the real email by adding an appropriate suffix to the commit url. I do wonder if they realise that - or even that they can just pull the damned git sources themselves over http? Or is the issue the rate limiting? Maybe that's where we need focus next? |
It's hard to rate limit anyway if they are using tons of random IP addresses |
fix #12296