Skip to content

Remove librejs header in <head> #12439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2020
Merged

Remove librejs header in <head> #12439

merged 2 commits into from
Aug 6, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Aug 5, 2020 •
edited
Loading

For the sake of performance and simplicity, remove this seemingly useless license header. It's related to LibreJS which we already pretty much killed of in an earlier commit [1]. Initially added in [2]. Note that the StaticUrlPrefix here was never actually correctly resolved and has rendered including the template fences.

[1] #11810
[2] a915a09

@silverwind
Remove librejs header in <head>
16a570b 
For the sake of performance and simplicity, remove this seemingly useless
license header. It's related to LibreJS which we already pretty much
killed of in an earlier commit [1]. Initially added in [2]. Note that
the StaticUrlPrefix here was never actually correctly resolved and has
rendered including the template fences.

[1] go-gitea#11810
[2] go-gitea@a915a09
@silverwind
Copy link
Member Author

silverwind commented Aug 5, 2020 •
edited
Loading

The SafeJS helper can not be directly removed because one other place in the code uses it. I could not quite figure out what it does but it may be ripe to remove if I do.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 5, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 5, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 6, 2020
@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 6, 2020
@techknowlogick techknowlogick added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Aug 6, 2020
@lunny lunny merged commit 983cbb2 into go-gitea:master Aug 6, 2020
@silverwind silverwind deleted the rmlic branch August 6, 2020 05:21
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @techknowlogick @zeripath @lunny @GiteaBot