Skip to content

[WIP] Feature/docker updates #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

xinity
Copy link
Contributor

@xinity xinity commented Nov 9, 2016

WIP docker cleanup.

has been done so far:

  • remove build from Dockerfile
  • cleanup start.sh (only crond exists)
  • readme.md updates

note: doesn't build for now but very soon :)

@xinity xinity added type/enhancement An improvement of existing functionality pr/wip This PR is not ready for review labels Nov 9, 2016
@xinity xinity added this to the 1.0.0 milestone Nov 9, 2016
@xinity xinity self-assigned this Nov 9, 2016
@codecov-io
Copy link

codecov-io commented Nov 9, 2016

Current coverage is 3.14% (diff: 100%)

Merging #125 into master will not change coverage

@@            master      #125   diff @@
========================================
  Files           33        33          
  Lines         7823      7823          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7557      7557          
  Partials        20        20          

Powered by Codecov. Last update 475ddd8...65afc95

5. If you're interested in using APIs, we have experimental support with [documentation](https://godoc.org/github.com/go-gitea/go-sdk).
6. If your team/company is using Gogs and would like to put your logo on [our website](https://gogs.io), contact us by any means.
1. **YOU MUST READ THE [Contributors Guide](https://github.com/go-gitea/gitea/CONTRIBUTING.md) BEFORE STARTING TO WORK ON A PULL REQUEST**.
4. If you think there are vulnerabilities in the project, please talk privately to **[email protected]**. Thanks!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the list numbers ;)

6. If your team/company is using Gogs and would like to put your logo on [our website](https://gogs.io), contact us by any means.
1. **YOU MUST READ THE [Contributors Guide](https://github.com/go-gitea/gitea/CONTRIBUTING.md) BEFORE STARTING TO WORK ON A PULL REQUEST**.
4. If you think there are vulnerabilities in the project, please talk privately to **[email protected]**. Thanks!
6. If your team/company is using Gogs and would like to put your logo on [our website](https://gitea.io), contact us by any means.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gogs :trollface:

@@ -69,15 +60,14 @@ The goal of this project is to make the easiest, fastest, and most painless way

## Installation

Make sure you install the [prerequisites](https://gogs.io/docs/installation) first.
**Note: As Gitea is a [Gogs](https://github.com/gogits/gogs) fork, tutorials and documentation related to gogs applies to Gitea too**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gogs should be Capitalized :)


- [Install from binary](https://gogs.io/docs/installation/install_from_binary.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove binary, source and package?


```
# Create docker volume.
$ docker volume create --name gogs-data
$ docker volume create --name gitea-data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's techincally no need for this, since docker run will auto-create it if it doesn't exist

### Container options

This container have some options available via environment variables, these options are opt-in features that can help the administration of this container:

- **SOCAT_LINK**:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has socat-support been removed?

@@ -99,11 +87,11 @@ This container have some options available via environment variables, these opti

:exclamation::exclamation::exclamation:<span style="color: red">**Make sure you have volumed data to somewhere outside Docker container**</span>:exclamation::exclamation::exclamation:

Steps to upgrade Gogs with Docker:
Steps to upgrade gitea with Docker:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitea capitalized

@tboerger tboerger mentioned this pull request Nov 28, 2016
@tboerger
Copy link
Member

Should we take #288 in favor of this?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 28, 2016
@tboerger
Copy link
Member

Thanks for the work, we have merged #288 now to properly build docker images.

@tboerger tboerger closed this Nov 29, 2016
@tboerger tboerger removed this from the 1.0.0 milestone Nov 29, 2016
@tboerger tboerger added issue/duplicate The issue has already been reported. and removed type/enhancement An improvement of existing functionality lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. pr/wip This PR is not ready for review labels Nov 29, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants