-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Use Node 14 on CI #12512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Node 14 on CI #12512
Conversation
Node 14 is sufficiently stable now, use it on CI.
Codecov Report
@@ Coverage Diff @@
## master #12512 +/- ##
==========================================
- Coverage 43.54% 43.52% -0.03%
==========================================
Files 637 637
Lines 70825 70825
==========================================
- Hits 30844 30829 -15
- Misses 34978 34992 +14
- Partials 5003 5004 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you bump makefile to have node 12 as minimum node version? Also update docs?
The minimum version will stay at 10.13 for now, this just raises the version used on CI. It does change the build step because I think it makes more sense to install dependencies and build on the same version and 14 also brings some performance improvements over 10. We lose the verification that it still builds on 10 this way but I don't think doing another 6-minute build is justified for it. |
🚀 |
Node 14 is sufficiently stable now, use it on CI. Also switched the build step to it as I think it makes more sense to run the build on the same version the dependencies were installed for, even if we're missing out a validation by running the old version.