Skip to content

Use Node 14 on CI #12512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 20, 2020
Merged

Use Node 14 on CI #12512

merged 7 commits into from
Aug 20, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Aug 17, 2020

Node 14 is sufficiently stable now, use it on CI. Also switched the build step to it as I think it makes more sense to run the build on the same version the dependencies were installed for, even if we're missing out a validation by running the old version.

Node 14 is sufficiently stable now, use it on CI.
@codecov-commenter
Copy link

Codecov Report

Merging #12512 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12512      +/-   ##
==========================================
- Coverage   43.54%   43.52%   -0.03%     
==========================================
  Files         637      637              
  Lines       70825    70825              
==========================================
- Hits        30844    30829      -15     
- Misses      34978    34992      +14     
- Partials     5003     5004       +1     
Impacted Files Coverage Δ
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-3.27%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
services/mirror/mirror.go 18.21% <0.00%> (-1.49%) ⬇️
models/error.go 34.81% <0.00%> (-0.52%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
models/issue_comment.go 53.75% <0.00%> (-0.16%) ⬇️
routers/repo/view.go 37.98% <0.00%> (+0.64%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02fbe1e...fefbdb4. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2020
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump makefile to have node 12 as minimum node version? Also update docs?

@silverwind
Copy link
Member Author

silverwind commented Aug 18, 2020

The minimum version will stay at 10.13 for now, this just raises the version used on CI.

It does change the build step because I think it makes more sense to install dependencies and build on the same version and 14 also brings some performance improvements over 10. We lose the verification that it still builds on 10 this way but I don't think doing another 6-minute build is justified for it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 18, 2020
@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Aug 18, 2020
@lafriks lafriks added this to the 1.13.0 milestone Aug 18, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 19, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit f19cac4 into go-gitea:master Aug 20, 2020
@silverwind silverwind deleted the node14 branch August 20, 2020 16:54
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants