Skip to content

Fix bug on migration 147 #12565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 22, 2020

As title.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 22, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 22, 2020
@zeripath
Copy link
Contributor

Sorry

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 22, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12565 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12565   +/-   ##
=======================================
  Coverage   43.45%   43.45%           
=======================================
  Files         643      643           
  Lines       71155    71165   +10     
=======================================
+ Hits        30917    30924    +7     
- Misses      35229    35233    +4     
+ Partials     5009     5008    -1     
Impacted Files Coverage Δ
models/migrations/v147.go 0.00% <0.00%> (ø)
modules/charset/charset.go 68.53% <0.00%> (-6.75%) ⬇️
modules/queue/unique_queue_channel.go 58.06% <0.00%> (-6.46%) ⬇️
services/gitdiff/gitdiff.go 74.54% <0.00%> (-1.81%) ⬇️
models/issue_comment.go 53.90% <0.00%> (+0.15%) ⬆️
services/pull/pull.go 42.03% <0.00%> (+0.46%) ⬆️
modules/git/repo.go 49.74% <0.00%> (+0.50%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
services/mirror/mirror.go 19.93% <0.00%> (+1.35%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8a05c...59fe3d3. Read the comment docs.

@zeripath zeripath merged commit 2026d88 into go-gitea:master Aug 22, 2020
@lunny lunny deleted the lunny/fix_migrate_147 branch August 23, 2020 00:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants