Add github api token option to generate-license & generate-gitignore #12683
Conversation
Without api toke, Will face rate limit sometimes. Signed-off-by: a1012112796 <[email protected]>
| flag.Parse() | ||
|
|
||
| if len(githubApiToken) > 0 { | ||
| url += "?token=" + githubApiToken |
There was a problem hiding this comment.
Token being passed via query string is deprecated with github. Source: https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters
There was a problem hiding this comment.
So those links imply we could just use BASIC Auth with the token so I guess that would be the thing to do
There was a problem hiding this comment.
I see, but I'm sorry, I don't know how to do it. So I will close this pr, and look forward to other contributors doing it. Thanks.
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #12683 +/- ##
==========================================
- Coverage 43.29% 43.28% -0.01%
==========================================
Files 646 646
Lines 71592 71592
==========================================
- Hits 30993 30992 -1
- Misses 35583 35584 +1
Partials 5016 5016
Continue to review full report at Codecov.
|
Without api toke, Will face rate limit sometimes.