Skip to content

Fix go1.15 lint error in modules/public/public.go #12707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2020
Merged

Fix go1.15 lint error in modules/public/public.go #12707

merged 3 commits into from
Sep 4, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 4, 2020

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 4, 2020
@lunny lunny added the type/bug label Sep 4, 2020
@lunny lunny added this to the 1.13.0 milestone Sep 4, 2020
@6543 6543 mentioned this pull request Sep 4, 2020
Merged
@6543
Copy link
Member Author

6543 commented Sep 4, 2020

@lunny #12708

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #12707 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12707      +/-   ##
==========================================
- Coverage   43.30%   43.29%   -0.01%     
==========================================
  Files         646      646              
  Lines       71567    71567              
==========================================
- Hits        30989    30984       -5     
+ Misses      35561    35560       -1     
- Partials     5017     5023       +6
Impacted Files Coverage Δ
modules/public/public.go 56.16% <0.00%> (ø)
modules/indexer/stats/db.go 43.47% <0.00%> (-17.40%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 41.57% <0.00%> (-0.47%) ⬇️
modules/log/event.go 59.43% <0.00%> (+1.88%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f083bd7...b23c477. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 4, 2020
@lafriks lafriks added topic/code-linting backport/v1.12 backport/done All backports for this PR have been created labels Sep 4, 2020
lafriks pushed a commit that referenced this pull request Sep 4, 2020
@6543
[Backport] Fix go1.15 lint error in modules/public/public.go (#12707) (…
2806a31 
…#12708)

* fix go1.15 lint error in modules/public/public.go

* CI.restart()
@6543
Copy link
Member Author

6543 commented Sep 4, 2020

🚀

@lafriks lafriks merged commit d745610 into go-gitea:master Sep 4, 2020
@lafriks lafriks deleted the fix-go1.15-lint branch September 4, 2020 13:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @codecov-commenter @lunny @lafriks @GiteaBot