Skip to content

Implemet Cache for Stopwatches.APIFormat() #12730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 5, 2020

extract from #12729 for v1.13.0 release

@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 5, 2020
@6543 6543 added this to the 1.13.0 milestone Sep 5, 2020
@6543 6543 added the modifies/api This PR adds API routes or modifies them label Sep 5, 2020
@6543
Copy link
Member Author

6543 commented Sep 5, 2020

loading issues and repos is now neede because of #12458 witch is in v1.13.0

this pull make it more efficient

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 5, 2020
@6543
Copy link
Member Author

6543 commented Sep 5, 2020

@techknowlogick hope you dont mind :)

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2020

Codecov Report

Merging #12730 into master will increase coverage by 0.03%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12730      +/-   ##
==========================================
+ Coverage   43.38%   43.41%   +0.03%     
==========================================
  Files         648      648              
  Lines       71548    71569      +21     
==========================================
+ Hits        31042    31073      +31     
+ Misses      35475    35468       -7     
+ Partials     5031     5028       -3     
Impacted Files Coverage Δ
models/issue_stopwatch.go 73.33% <84.00%> (+2.79%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/git/repo.go 49.74% <0.00%> (+0.50%) ⬆️
modules/log/event.go 59.43% <0.00%> (+1.88%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
modules/indexer/stats/queue.go 76.47% <0.00%> (+11.76%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+17.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f10d3ea...94481a7. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 5, 2020
@techknowlogick techknowlogick merged commit 1c35353 into go-gitea:master Sep 6, 2020
@6543 6543 deleted the cache-for-stopwatches-apiformat branch September 6, 2020 02:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants