Skip to content

Clarification on the use of certificate chains #12986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2020

Conversation

PE1NUT
Copy link
Contributor

@PE1NUT PE1NUT commented Sep 30, 2020

This pull request adds a little more detail to the documentation on the use of TLS certificates. As it took me a while to figure out why gitea would work with the server certificate, but not the full chain (which was ordered incorrectly), I think that a bit of clarification may help others in the future. Feel free to reject if this is considered canonical knowledge when working with X509 certificates.

This would close issue #12972.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #12986 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12986      +/-   ##
==========================================
- Coverage   42.59%   42.59%   -0.01%     
==========================================
  Files         671      671              
  Lines       73625    73625              
==========================================
- Hits        31363    31358       -5     
- Misses      37180    37184       +4     
- Partials     5082     5083       +1     
Impacted Files Coverage Δ
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615e784...af37aa6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 30, 2020
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Sep 30, 2020
Co-authored-by: Bagas Sanjaya <[email protected]>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 30, 2020
@techknowlogick techknowlogick merged commit f2c29f2 into go-gitea:master Sep 30, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants