resolved LFS over SSH - #1296 (parsing payload string) #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks if that string has additional elemets following. Resolves #1296
|
@fabian-z maybe you can help to confirm this PR. |
tboerger
added
the
lgtm/need 2
|
The command passed to the ssh authentication logic seems to be invalid according to the spec, causing issue with the string parsing. This should not be merged since it targets the wrong place in the code for the issue to be handled. The relevant code is in cmd/serv.go. |
|
This PR was superseded by #1328 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #1296
I managed to find a quick solution to the 401 error I've been getting.
The payload has a string "upload" followed by a hex string - and the line of code I changed ensures that the comparison works in either case.