Skip to content

Don't show "0" labels on repo tabs #13289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Conversation

silverwind
Copy link
Member

If count is zero, don't show the label, matching GH behavior.

Before:
Screen Shot 2020-10-24 at 11 59 58
After:
Screen Shot 2020-10-24 at 12 00 21

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Oct 24, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 24, 2020
If count is zero, don't show the label, matching GH behavior.
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2020
@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #13289 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13289      +/-   ##
==========================================
- Coverage   42.16%   42.15%   -0.01%     
==========================================
  Files         685      685              
  Lines       75571    75571              
==========================================
- Hits        31867    31860       -7     
- Misses      38482    38489       +7     
  Partials     5222     5222              
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
routers/repo/view.go 37.47% <0.00%> (-0.65%) ⬇️
services/pull/check.go 49.63% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0800c7e...5ea5315. Read the comment docs.

@lafriks lafriks merged commit a69e112 into go-gitea:master Oct 24, 2020
@silverwind silverwind deleted the num-tabs branch October 24, 2020 11:55
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants