Precompile fomantic-ui files #13332
Merged
Precompile fomantic-ui files #13332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
the
topic/build
6543
approved these changes
Oct 27, 2020
GiteaBot
added
the
lgtm/need 1
silverwind
force-pushed
the
fomantic-prebuild
branch
2 times, most recently
from
0de1586 to
760e379
Compare
We rarely change fomantic-ui or its configuration so it's kind of a waste to have it rebuild on every CI run. These changes remove the fomantic files from the build and instead add the relevant output files to the git index, which should shave of 2-3 minutes on every CI run. `make fomantic` should still work and should be ran whenever fomantic is updated or its configuration is changed.
silverwind
force-pushed
the
fomantic-prebuild
branch
from
760e379 to
57692fe
Compare
zeripath
approved these changes
Oct 27, 2020
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #13332 +/- ##
==========================================
- Coverage 42.11% 42.11% -0.01%
==========================================
Files 689 689
Lines 75846 75846
==========================================
- Hits 31942 31941 -1
- Misses 38671 38672 +1
Partials 5233 5233
Continue to review full report at Codecov.
|
|
Oddly, the fomantic build still seem to have ran on the master build https://drone.gitea.io/go-gitea/gitea/31821/1/7 but not on the PR build https://drone.gitea.io/go-gitea/gitea/31812/1/7. |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Oct 28, 2020
Followup to go-gitea#13332. Turns out I missed this dependency which resulted in fomantic-ui being uselessly rebuild on CI. This fully removes it from the chain so it's not attempted to be build as part of the main build process.
zeripath
pushed a commit
that referenced
this pull request
Oct 28, 2020
Followup to #13332. Turns out I missed this dependency which resulted in fomantic-ui being uselessly rebuild on CI. This fully removes it from the chain so it's not attempted to be build as part of the main build process.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rarely change fomantic-ui or its configuration so it's kind of a waste to have it rebuild on every CI run. These changes remove the fomantic files from the build and instead add the relevant output files to the git index, which should shave of 2-3 minutes on every CI run.
make fomanticshould still work and should be ran whenever fomantic is updated or its configuration is changed.