-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Skip appending authorized_keys file if asked not to #13368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
techknowlogick
merged 4 commits into
go-gitea:master
from
sapk-fork:force-create-auth-key
Nov 1, 2020
Merged
Skip appending authorized_keys file if asked not to #13368
techknowlogick
merged 4 commits into
go-gitea:master
from
sapk-fork:force-create-auth-key
Nov 1, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
approved these changes
Oct 31, 2020
silverwind
approved these changes
Oct 31, 2020
zeripath
approved these changes
Oct 31, 2020
Please update branch with base |
lafriks
approved these changes
Oct 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #13368 +/- ##
==========================================
- Coverage 42.13% 42.11% -0.02%
==========================================
Files 691 691
Lines 75909 75909
==========================================
- Hits 31983 31969 -14
- Misses 38687 38700 +13
- Partials 5239 5240 +1
Continue to review full report at Codecov.
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/miscellaneous
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a missing check before writing authorized_keys file.
Before appending to the file we should check that this function is not deactivated like here:
gitea/models/ssh_key.go
Line 707 in 9066d09
gitea/cmd/doctor.go
Line 395 in 1b9d507