Skip to content

Misc UI fixes, add secondary color #13378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 1, 2020
Merged

Misc UI fixes, add secondary color #13378

merged 8 commits into from
Nov 1, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 1, 2020 •
edited
Loading

  • Add secondary color, primarily used in arc-green currently
  • Convert icons on release page to SVG
  • Improve resolved conversation placeholder
  • Diff fixes on arc-green
  • Misc color tweaks

Screen Shot 2020-11-01 at 01 25 08

Screen Shot 2020-11-01 at 02 16 35

Screen Shot 2020-11-01 at 02 17 31

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 1, 2020
@silverwind silverwind force-pushed the csstweaks3 branch 3 times, most recently from 80cfcdb to a9b7f17 Compare November 1, 2020 09:01
@silverwind silverwind changed the title Misc UI fixes Misc UI fixes, add secondary color Nov 1, 2020
@silverwind
Copy link
Member Author

Bundled in another change, the introduction of --color-secondary which makes more sense to me than --color-border introduced earlier.

Primarily used in arc-green currently. We may be able to use it in the gitea theme more but I guess for that we'll need to either alter fomantic's theme or preprocess fomantic.

@silverwind
Misc UI fixes, add secondary color
69ba44f 
- Add secondary color, primarily used in arc-green currently
- Convert icons on release page to SVG
- Improve resolved conversation placeholder
- Diff fixes on arc-green
- Misc color tweaks
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Nov 1, 2020
@zeripath zeripath added this to the 1.14.0 milestone Nov 1, 2020
@silverwind silverwind mentioned this pull request Nov 1, 2020
Merged
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 1, 2020
@techknowlogick techknowlogick merged commit 4617bb6 into go-gitea:master Nov 1, 2020
@silverwind silverwind deleted the csstweaks3 branch November 1, 2020 20:41
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @techknowlogick @lafriks @zeripath @GiteaBot