Skip to content

Fix double border introduced by #13434 #13457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Nov 7, 2020

Quick fix for #13434 introducing double border on certain elements.

Before:

chrome_2020-11-07_17-12-55
chrome_2020-11-07_17-13-58
chrome_2020-11-07_17-12-12


After:

chrome_2020-11-07_17-10-14
chrome_2020-11-07_17-10-31
chrome_2020-11-07_17-10-46

@CirnoT
Copy link
Contributor Author

CirnoT commented Nov 7, 2020

Would like @silverwind to check this out before merging.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 7, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 7, 2020
@lafriks lafriks added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 7, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 7, 2020
@lafriks lafriks requested a review from silverwind November 7, 2020 16:21
@silverwind
Copy link
Member

silverwind commented Nov 7, 2020

Looks good.

There are some minor issue visible on your screenshot with the triangles on the left side of the header I just noticed, maybe you can fix those too while you're at it:

Background too bright:
image

Triangle not centered:
image

@CirnoT
Copy link
Contributor Author

CirnoT commented Nov 7, 2020

Outside of scope for this PR really, there are more places where these triangles are off-centered or broken (often in color or positioning).

@silverwind
Copy link
Member

Hmm yeah, can check that separately.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #13457 (e56b508) into master (7c47e24) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13457   +/-   ##
=======================================
  Coverage   42.11%   42.12%           
=======================================
  Files         692      692           
  Lines       75985    75985           
=======================================
+ Hits        32003    32009    +6     
+ Misses      38738    38734    -4     
+ Partials     5244     5242    -2     
Impacted Files Coverage Δ
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
services/pull/check.go 52.55% <0.00%> (+0.72%) ⬆️
modules/git/repo.go 47.71% <0.00%> (+1.52%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c47e24...e56b508. Read the comment docs.

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit f719e2e into go-gitea:master Nov 7, 2020
@CirnoT CirnoT deleted the fix-13434 branch November 8, 2020 00:13
CirnoT added a commit to CirnoT/gitea that referenced this pull request Nov 9, 2020
techknowlogick pushed a commit that referenced this pull request Nov 10, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants