fix: issue tracker link redirection #13504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kudos to @zeripath * in case there is a remote issue tracker configured, the git graph view PR and issue links now correctly point to the issue tracker location, whereas if literally pointing at 'pulls', you could have ended up back at the local instance after clicking the link (which, obviously haven't had the pull/issue) Signed-off-by: wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf <[email protected]>
zeripath
approved these changes
Nov 10, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Nov 10, 2020
GiteaBot
added
lgtm/done
lafriks
added
type/bug
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, kudos to @zeripath for telling me what to do to fix the issue.
There's this issue I've got and this PR fixes it.
In case a repo has got a remote issue tracker configured, the git graph view PR and issue links now correctly point to the issue tracker location, whereas before they were literally pointing at 'pulls' (
/usr/repo/pulls) and you could have ended up back at the local instance after clicking the link (which, obviously haven't had the pull/issue).I case there is no remote issue tracker configured, no redirection occurs and a proper issue/PR page is shown.