Fix label display on new issues #13590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR go-gitea#13570 broke label rendering for new issues and pulls because missed the fact that the code was relying on the DOM elements being toggled by JavaScript. On top of that, the label rendering for new issues and pull was using an outdated template which I consolidated in a new shared template.
silverwind
force-pushed
the
labelsfix
branch
from
80da728 to
b545c86
Compare
lafriks
approved these changes
Nov 16, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
added
type/bug
skip-changelog
|
One more adjustment pushed. Removal of wrapper element and 1px more margin between labels:
|
mrsdizzie
reviewed
Nov 16, 2020
mrsdizzie
approved these changes
Nov 17, 2020
GiteaBot
added
lgtm/done
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #13570 broke label rendering for new issues and pulls because I missed the fact that the code was relying on the DOM elements being toggled by JavaScript.
On top of that, the label rendering for new issues and pull was using an outdated template which I consolidated in a new shared template.