Skip to content

Fix a bug when check if owner is active #13612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

Fix a bug when check if owner is active #13612

merged 1 commit into from
Nov 18, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 18, 2020

Fix #13589

@lunny lunny added this to the 1.14.0 milestone Nov 18, 2020
@lunny lunny mentioned this pull request Nov 18, 2020
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Nov 18, 2020
@lunny lunny mentioned this pull request Nov 18, 2020
Merged
@codecov-io
Copy link

Codecov Report

Merging #13612 (4cd7357) into master (76cdf3b) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13612      +/-   ##
==========================================
+ Coverage   42.19%   42.20%   +0.01%     
==========================================
  Files         697      697              
  Lines       76563    76563              
==========================================
+ Hits        32305    32314       +9     
+ Misses      38957    38950       -7     
+ Partials     5301     5299       -2
Impacted Files Coverage Δ
routers/private/serv.go 28.08% <0.00%> (ø)
routers/repo/http.go 42.45% <0.00%> (ø)
services/pull/check.go 48.90% <0.00%> (-0.73%) ⬇️
services/pull/pull.go 41.27% <0.00%> (+0.49%) ⬆️
modules/log/event.go 61.79% <0.00%> (+1.88%) ⬆️
modules/charset/charset.go 73.03% <0.00%> (+4.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76cdf3b...4cd7357. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 18, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 18, 2020
@lafriks lafriks merged commit 5a991ec into go-gitea:master Nov 18, 2020
@lunny lunny deleted the lunny/fix_bug branch November 18, 2020 11:13
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Unauthorized error when owner is not a user in gitea
5 participants
@lunny @codecov-io @silverwind @lafriks @GiteaBot