Skip to content

finaly fix gitlab migration with subdir #13629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2020
Merged

finaly fix gitlab migration with subdir #13629

merged 2 commits into from
Nov 19, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 19, 2020 •
edited
Loading

close #13535

@6543 6543 added topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality labels Nov 19, 2020
@6543 6543 added this to the 1.14.0 milestone Nov 19, 2020
@6543 6543 added the pr/wip This PR is not ready for review label Nov 19, 2020
@codecov-io
Copy link

codecov-io commented Nov 19, 2020 •
edited
Loading

Codecov Report

Merging #13629 (53b500d) into master (12c2efb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13629      +/-   ##
==========================================
- Coverage   42.20%   42.18%   -0.02%     
==========================================
  Files         697      697              
  Lines       76571    76576       +5     
==========================================
- Hits        32314    32306       -8     
- Misses      38959    38970      +11     
- Partials     5298     5300       +2
Impacted Files Coverage Δ
modules/migrations/gitlab.go 0.99% <0.00%> (-0.02%) ⬇️
modules/avatar/avatar.go 50.00% <0.00%> (-4.77%) ⬇️
modules/queue/manager.go 62.13% <0.00%> (-2.96%) ⬇️
routers/repo/view.go 37.47% <0.00%> (-0.65%) ⬇️
routers/api/v1/repo/pull.go 24.84% <0.00%> (-0.61%) ⬇️
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6626a04...492945c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 19, 2020
@6543 6543 force-pushed the gitlab-migration_be-more-tollerant branch from 5f112f3 to 53b500d Compare November 19, 2020 01:42
@6543 6543 changed the title migrate: gitlab: only try split namespace & subdir if authenticated, … finaly fix gitlab migration with subdir Nov 19, 2020
@6543 6543 added type/bug and removed type/enhancement An improvement of existing functionality pr/wip This PR is not ready for review labels Nov 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 19, 2020
@techknowlogick techknowlogick merged commit ad2a288 into go-gitea:master Nov 19, 2020
techknowlogick pushed a commit to techknowlogick/gitea that referenced this pull request Nov 19, 2020
@6543 @techknowlogick
finaly fix gitlab migration with subdir (go-gitea#13629)
ed56db1 
* finaly fix go-gitea#13535

* add logging
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Nov 19, 2020
@techknowlogick
Copy link
Member

backport PR created at #13633

@lafriks lafriks deleted the gitlab-migration_be-more-tollerant branch November 19, 2020 05:34
techknowlogick added a commit that referenced this pull request Nov 19, 2020
@techknowlogick @6543
finaly fix gitlab migration with subdir (#13629) (#13633)
e0d28e2 
* finaly fix #13535

* add logging

Co-authored-by: 6543 <[email protected]>
@6543 6543 mentioned this pull request Nov 19, 2020
Merged
9 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@gary-kim gary-kim gary-kim approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Wrong URL when importing from GitLab hosted in subdirectory
6 participants
@6543 @codecov-io @techknowlogick @zeripath @gary-kim @GiteaBot