Skip to content

Fix heatmap rendering in Chrome and Safari #13645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 23, 2020
Merged

Fix heatmap rendering in Chrome and Safari #13645

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
923a115
Fix heatmap rendering in Chrome and Safari
silverwind Nov 19, 2020
8ad4962
position tweak
silverwind Nov 19, 2020
94fe2e1
Merge branch 'master' into fix-heatmap
zeripath Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions web_src/less/features/heatmap.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
align-items: center;
justify-content: center;

> svg {
width: 100%;
}

svg:not(:root) {
overflow: inherit;
padding: 0 !important;
Expand All @@ -16,13 +20,6 @@
fill: currentColor !important;
}

@media @mediaLgAndDown {
&,
& + .divider {
display: none;
}
}

.total-contributions {
font-size: 11px;
position: absolute;
Expand All @@ -31,20 +28,38 @@
}

@media @mediaLgAndDown {
& {
min-height: 105px;
}
.total-contributions {
left: 21px;
}
}

@media (max-width: 1000px) {
& {
min-height: 80px;
}
.total-contributions {
font-size: 10px;
left: 17px;
bottom: -2px;
bottom: -4px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

liked this better aligned with inline

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely positioned, display: inline on the parent wouldn't do anything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely positioned, display: inline on the parent wouldn't do anything.

not here but on the user-heatmap div and I think it's more elegant that way.
then this would not be needed.
but if it works, it works.

}
}
}

.user.profile #user-heatmap {
min-height: 135px;
}

@media @mediaLgAndDown {
.user.profile #user-heatmap {
min-height: 115px;
}
}

@media (max-width: 1000px) {
.user.profile #user-heatmap {
min-height: 90px;
}
}