Skip to content

[Vendor] Update go-redis to v8.5.0 #13749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Feb 10, 2021
Merged

[Vendor] Update go-redis to v8.5.0 #13749

merged 22 commits into from
Feb 10, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 29, 2020

as title

@6543 6543 added dependencies type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Nov 29, 2020
@6543 6543 added this to the 1.14.0 milestone Nov 29, 2020
@6543 6543 changed the title Update go-redis to v8.4.0 [Vendor] Update go-redis to v8.4.0 Nov 29, 2020
silverwind
silverwind reviewed Nov 29, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 29, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 29, 2020
@codecov-io
Copy link

codecov-io commented Nov 29, 2020 •
edited
Loading

Codecov Report

Merging #13749 (260e919) into master (c10503a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13749      +/-   ##
==========================================
- Coverage   42.11%   42.11%   -0.01%     
==========================================
  Files         758      758              
  Lines       81104    81107       +3     
==========================================
  Hits        34160    34160              
- Misses      41367    41369       +2     
- Partials     5577     5578       +1
Impacted Files Coverage Δ
modules/cache/cache_redis.go 3.17% <0.00%> (ø)
modules/nosql/manager.go 38.09% <ø> (ø)
modules/nosql/manager_redis.go 0.00% <ø> (ø)
modules/queue/queue_redis.go 4.76% <0.00%> (ø)
modules/queue/unique_queue_redis.go 4.25% <0.00%> (ø)
modules/session/redis.go 2.08% <0.00%> (-0.07%) ⬇️
modules/indexer/stats/db.go 56.00% <0.00%> (-12.00%) ⬇️
modules/git/repo_language_stats_nogogit.go 57.44% <0.00%> (-6.39%) ⬇️
modules/git/batch_reader_nogogit.go 44.77% <0.00%> (-1.50%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1080b27...260e919. Read the comment docs.

zeripath
zeripath reviewed Nov 29, 2020
View reviewed changes
@6543 6543 added the pr/wip This PR is not ready for review label Nov 29, 2020
@6543 6543 force-pushed the vendor_redis-migrate-v8 branch from ee0ee2b to 4159d79 Compare November 30, 2020 12:06
@6543 6543 removed the pr/wip This PR is not ready for review label Nov 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 3, 2020
zeripath
zeripath reviewed Dec 3, 2020
View reviewed changes
@6543 6543 added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Dec 3, 2020
zeripath
zeripath previously requested changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Queue's contexts are incorrect - please don't merge until I've thought more.

@lunny
Copy link
Member

lunny commented Jan 27, 2021

Please resolve the conflicts.

@6543
Copy link
Member Author

6543 commented Feb 2, 2021

@zeripath do you have an advice?

@6543 6543 changed the title [Vendor] Update go-redis to v8.4.0 [Vendor] Update go-redis to v8.5.0 Feb 7, 2021
zeripath
zeripath reviewed Feb 9, 2021
View reviewed changes
zeripath
zeripath reviewed Feb 9, 2021
View reviewed changes
zeripath
zeripath reviewed Feb 9, 2021
View reviewed changes
zeripath
zeripath reviewed Feb 9, 2021
View reviewed changes
@zeripath zeripath dismissed their stale review February 10, 2021 19:02

Problems are now sorted to the best we can do

@zeripath
missed one
6bf9f20 
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Feb 10, 2021
@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit ac97ea5 into go-gitea:master Feb 10, 2021
@6543 6543 deleted the vendor_redis-migrate-v8 branch February 10, 2021 22:17
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath left review comments

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @codecov-io @lunny @zeripath @silverwind @GiteaBot