Skip to content

Fix branch/tag notifications in mirror sync #13855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2020
Merged

Fix branch/tag notifications in mirror sync #13855

merged 3 commits into from
Dec 5, 2020

Conversation

manuelluis
Copy link
Contributor

@manuelluis manuelluis commented Dec 4, 2020 •
edited
Loading

Fix: #13810

@codecov-io
Copy link

codecov-io commented Dec 4, 2020 •
edited
Loading

Codecov Report

Merging #13855 (aadda8f) into master (d0d59e3) will increase coverage by 0.01%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13855      +/-   ##
==========================================
+ Coverage   42.25%   42.26%   +0.01%     
==========================================
  Files         708      708              
  Lines       77173    77190      +17     
==========================================
+ Hits        32608    32626      +18     
+ Misses      39198    39196       -2     
- Partials     5367     5368       +1
Impacted Files Coverage Δ
services/mirror/mirror.go 16.89% <11.76%> (+0.90%) ⬆️
modules/indexer/stats/queue.go 52.94% <0.00%> (-11.77%) ⬇️
modules/queue/unique_queue_channel.go 58.06% <0.00%> (-6.46%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-2.25%) ⬇️
services/gitdiff/gitdiff.go 69.05% <0.00%> (-1.94%) ⬇️
services/pull/pull.go 40.68% <0.00%> (-0.50%) ⬇️
models/issue_comment.go 52.87% <0.00%> (+0.15%) ⬆️
models/error.go 38.66% <0.00%> (+0.48%) ⬆️
modules/git/repo.go 46.23% <0.00%> (+0.50%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d59e3...aadda8f. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2020
lunny
lunny reviewed Dec 5, 2020
View reviewed changes
@lunny lunny added this to the 1.14.0 milestone Dec 5, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 5, 2020
@lunny lunny merged commit 8561f26 into go-gitea:master Dec 5, 2020
manuelluis pushed a commit to manuelluis/gitea that referenced this pull request Dec 5, 2020
Fix branch/tag notifications in mirror sync (go-gitea#13855)
2fb0e26
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Dec 5, 2020
techknowlogick pushed a commit that referenced this pull request Dec 6, 2020
@manuelluis @6543
Fix branch/tag notifications in mirror sync (#13855) (#13862)
cb24cbc 
Co-authored-by: Gitea <[email protected]>
Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Webhook not delivered for tag creation on mirror repo
6 participants
@manuelluis @codecov-io @lunny @lafriks @techknowlogick @GiteaBot