Skip to content

Reorganize Chroma styles #13934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2020
Merged

Reorganize Chroma styles #13934

merged 3 commits into from
Dec 11, 2020

Conversation

silverwind
Copy link
Member

This moves the Chroma styles into separate files with base,light and dark variants. Should work exactly as before.

@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 10, 2020
@silverwind silverwind added this to the 1.14.0 milestone Dec 10, 2020
@silverwind
Reorganize Chroma styles
d10cb63 
This moves the Chroma styles into separate files with base,light and
dark variants. Should work exactly as before.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 10, 2020
6543
6543 approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2020
@6543 6543 merged commit 160f606 into go-gitea:master Dec 11, 2020
@silverwind silverwind deleted the chromathemes branch December 11, 2020 17:23
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @mrsdizzie @zeripath @6543 @GiteaBot