-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Store repository data in data path if not previously set #13991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13991 +/- ##
==========================================
- Coverage 42.23% 42.21% -0.02%
==========================================
Files 710 710
Lines 77233 77230 -3
==========================================
- Hits 32617 32606 -11
- Misses 39245 39250 +5
- Partials 5371 5374 +3
Continue to review full report at Codecov.
|
it's nice cleanup for modules/setting/repository.go too ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update cheat sheet and app.example.ini (adding same comment there)
@silverwind thanks for reminder. I have now update docs. |
Still missing from |
Co-authored-by: silverwind <[email protected]>
@silverwind ah yes, I've also added in one unrelated part of docs too as it was empty and next to |
Fixes #12292 - stores snap repo data in common directory so it isn't set to store in previous snap version path.
Previously it is set to store repo data in $HOME if not set, instead this sets it to store in
AppDataPath
if not set. Checked for breaking on arch & alpine and doesn't break them, however as this changes a default setting I've marked it as breaking.