Skip to content

Fix merge button dropdown triangle alignment #14041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 19, 2020

Conversation

silverwind
Copy link
Member

#14028 had improved dropdown triangle display for buttons with text but had regressed it for buttons without. Fix this by adding a class to prevent horizontal margin adjustment.

Before:
Screen Shot 2020-12-17 at 20 42 50

After:
Screen Shot 2020-12-17 at 20 42 26

go-gitea#14028 had improved dropdown
triangle display for buttons with text but had regressed it for buttons
without. Fix this by adding a class to prevent horizontal margin adjustment.
@silverwind silverwind added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 17, 2020
@silverwind silverwind added this to the 1.14.0 milestone Dec 17, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 4aabbac into go-gitea:master Dec 19, 2020
@silverwind silverwind deleted the mergebtn branch December 19, 2020 09:29
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants